Ethereal-cvs: [Ethereal-cvs] rev 14648: /trunk/epan/dissectors/: Makefile.common packet-isakmp

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: guy@xxxxxxxxxxxx
Date: Thu, 16 Jun 2005 06:19:14 -0000
User: guy
Date: 2005/06/16 01:19 AM

Log:
 Static variables considered harmful.  Make the ISAKMP version a
 parameter to many functions inside the ISAKMP dissector, as well as to
 the "isakmp_dissect_payloads()" routine it exports.  Get rid of
 "isakmp_set_version()", as the version can be passed to
 "isakmp_dissect_payloads()" from the KINK dissector.
 
 Put the declaration of "isakmp_dissect_payloads()" into a
 "packet-isakmp.h" header, and have "packet-isakmp.c" and "packet-kink.h"
 include it rather than declariing "isakmp_dissect_payloads()" itself -
 or not doing so at all.

Directory: /trunk/epan/dissectors/
  Changes    Path               Action
  +1 -0      Makefile.common    Modified
  +117 -108  packet-isakmp.c    Modified
  +40 -0     packet-isakmp.h    Added
  +2 -5      packet-kink.c      Modified



http://anonsvn.ethereal.com/viewcvs/viewcvs.py?rev=14648&view=rev