Ethereal-cvs: [Ethereal-cvs] cvs commit: ethereal packet-clnp.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: guy@xxxxxxxxxxxx (Guy Harris)
Date: Sat, 19 Jun 2004 20:05:08 -0500 (CDT)
guy         2004/06/19 20:05:08 CDT

  Modified files:
    .                    packet-clnp.c 
  Log:
  The sequence number in COTP packets is either unused (for TP0) or
  relative to the beginning of the connection (for TP1-4).  They are *not*
  relative to the first segment of a segmented TPDU, so the sequence
  number can't be used in calls to "fragment_add_seq_check()".
  
  For now, we assume that COTP packets are seen in order, and just use
  "fragment_add_seq_next()" - that's unlikely to make anything worse (the
  only time when "fragment_add_seq_check()" will work is when the first
  segment has a sequence number of 0), and definitely fixes reassembly in
  a number of cases.  In the long term, we might want to handle
  out-of-order packets above the reassembly layer, so that it handles even
  out-of-order unsegmented packets.
  
  Revision  Changes    Path
  1.86      +12 -4     ethereal/packet-clnp.c