guy 2002/05/16 04:59:54 CDT
Modified files:
. ncp2222.py packet-ncp-int.h packet-ncp.c
packet-ncp2222.inc
Log:
Move the #defines for NCP packet types to "packet-ncp-int.h", and use
them in "packet-ncp2222.inc".
The page at
http://www.odyssea.com/whats_new/tcpipnet/tcpipnet.html
indicates that a positive ACK (0x9999) NCP packet has the same
completion code and connection status fields as a reply (0x3333) packet
(but nothing after them); hand "dissect_ncp_reply()" the packet type as
one of its arguments, and have it handle positive ACK packets as well as
reply packets.
It also indicates that bit 4 of the connection status indicates that the
server is unavailable, and the page at
http://www.unm.edu/~network/presentations/course/appendix/appendix_f/tsld088.htm
speaks of that and of the significance of other bits; put a comment in
"ncp2222.py", before the "hf_ncp_connection_status" field, about that.
From looking at a capture, it appears that a "destroy service
connection" (0x5555) packet should be treated like a "create service
connection" (0x1111) packet and be handed to "dissect_ncp_request()".
Note that perhaps watchdog packets should be handled by
"dissect_ncp_reply()" as well.
Revision Changes Path
1.20 +24 -1 ethereal/ncp2222.py
1.8 +15 -5 ethereal/packet-ncp-int.h
1.61 +11 -14 ethereal/packet-ncp.c
1.13 +23 -7 ethereal/packet-ncp2222.inc