guy 2001/06/10 04:50:19 CDT
Modified files:
. packet-ftp.c packet-snmp.c packet-tftp.c
Log:
Rename the arguments and flags for the conversation routines, so as not
to imply that
1) conversations have source and destination addresses and ports
- they don't (if they did, they'd be monologues, not
conversations), they just have two address/port pairs for the
two endpoints, with one or more of the address or port in the
second pair possibly being wildcarded;
2) the first and second address or port argument to
"find_conversation()" or "try_conversation_dissector()" have
anything to do with the first or second address/port pair in
a conversation - they don't, the two arguments to those
routines are matched against *both* address/port pairs for a
conversation;
as otherwise people might think that they need to add flags to wildcard
the first arguments "conversation_new()" or "find_conversation()" (they
don't, they just have to pass the non-wildcarded address/port first and
then pass the wildcarded one, even if that means passing the destination
first and source second).
Revision Changes Path
1.29 +4 -4 ethereal/packet-ftp.c
1.68 +15 -11 ethereal/packet-snmp.c
1.25 +13 -9 ethereal/packet-tftp.c