guy 2000/10/21 04:54:11 CDT
Modified files:
. Makefile.am packet-tftp.c packet-udp.c
Removed files:
. packet-tftp.h
Log:
Wildcard matching is tricky - you have to try wildcarding both the
source *and* destination port and/or both the source *and* destination
address passed to "find_conversation()", because the packet for which
you're trying to find the conversation may be going in the opposite
direction to the packet for which the conversation was originally
created.
Create different hash tables for wildcarded conversations, to reduce the
number of "is this a wildcard?" tests done when doing hash lookups.
This is sufficient to allow the TFTP dissector to use conversations
rather than being special-cased in the UDP dissector, and may also be
sufficient to handle a similar problem with SMTP (request goes from
client IP X port Y to server IP Z's well-known port, reply comes back
from some other port on server Z to client IP X port Y), but further use
may reveal other changes that should be made.
Revision Changes Path
1.238 +1 -2 ethereal/Makefile.am
1.14 +37 -3 ethereal/packet-tftp.c
1.76 +1 -7 ethereal/packet-udp.c