[Laurent Deniel <deniel@xxxxxxxxxxxx>]

deniel      2000/08/11 08:37:14 CDT

  Modified files:
    .                    xdlc.h strerror.h packet-smb.h 
                         packet-ypxfr.h packet-ypserv.h 
                         packet-ypbind.h packet-x11-declarations.h 
                         packet-x25.h packet-x11-keysym.h 
                         packet-vtp.h packet-vlan.h packet-v120.h 
                         packet-udp.h packet-trmac.h packet-tr.h 
                         packet-tftp.h packet-tcp.h packet-lapd.h 
                         packet-stat.h packet-sscop.h 
                         packet-snmp.h packet-sna.h 
                         packet-smb-common.h packet-sdp.h 
                         packet-rtp.h packet-rtcp.h packet-rpc.h 
                         packet-rip.h packet-raw.h packet-q931.h 
                         packet-q2931.h packet-ppp.h 
                         packet-ipsec.h packet-portmap.h 
                         packet-ospf.h packet-null.h 
                         packet-netbios.h packet-ncp-int.h 
                         packet-nbipx.h packet-llc.h packet-ldap.h 
                         packet-lapb.h packet-isl.h packet-ipx.h 
                         packet-ipp.h packet-http.h packet-fddi.h 
                         packet-eth.h packet-diameter.h 
                         packet-ddtp.h packet-clip.h packet-cgmp.h 
                         packet-cdp.h packet-bpdu.h packet-atm.h 
                         packet-atalk.h packet-ascend.h oui.h 
                         nlpid.h inet_v6defs.h inet_aton.h 
                         packet-kerberos.h file.c tvbuff.h 
                         ptvcursor.h print.h plugins.h 
                         packet-ripng.h globals.h file.h tvbuff.c 
                         ptvcursor.c packet.c proto.h packet.h 
                         dfilter.h capture.c prefs.c plugins.c 
                         column.c tethereal.c inet_pton.c 
                         inet_ntop.c util.c packet-tcp.c 
                         packet-srvloc.c packet-socks.c 
                         packet-sctp.c packet-rsvp.c 
                         packet-rlogin.c packet-pim.c packet-ntp.c 
                         packet-msproxy.c packet-mip.c 
                         packet-ldap.c packet-isis-clv.c 
                         packet-isakmp.c packet-ip.c packet-icq.c 
                         packet-icmpv6.c packet-bgp.c ipproto.c 
                         dfilter.c proto.c snprintf.h snprintf.c 
                         snprintf-imp.h 
  Log:
  Miscellaneous code cleaning
  
  - add <stdarg.h> or <varargs.h> in snprintf.h
    and remove those inclusions in the other #ifdef NEED_SNPRINTF_H codes
  
  - remove the check of multiple inclusions in source (.c)  code
    (there is a bit loss of _cpp_ performance, but I prefer the gain of
     code reading and maintenance; and nowadays, disk caches and VM are
     correctly optimized ;-).
  
  - protect all (well almost) header files against multiple inclusions
  
  - add header (i.e. GPL license) in some include files
  
  - reorganize a bit the way header files are included:
  
    First:
    #include <system_include_files>
    #include <external_package_include_files (e.g. gtk, glib etc.)>
    Then
    #include "ethereal_include_files"
  
    with the correct HAVE_XXX or NEED_XXX protections.
  
  - add some HAVE_XXX checks before including some system header files
  
  - add the same HAVE_XXX in wiretap as in ethereal
  
  Please forgive me, if I break something (I've only compiled and regression
  tested on Linux).
  
  Revision  Changes    Path
  1.14      +6 -1      ethereal/xdlc.h
  1.2       +6 -1      ethereal/strerror.h
  1.2       +5 -1      ethereal/packet-smb.h
  1.2       +23 -2     ethereal/packet-ypxfr.h
  1.2       +23 -2     ethereal/packet-ypserv.h
  1.2       +23 -2     ethereal/packet-ypbind.h
  1.2       +6 -1      ethereal/packet-x11-declarations.h
  1.7       +6 -1      ethereal/packet-x25.h
  1.2       +6 -1      ethereal/packet-x11-keysym.h
  1.2       +5 -1      ethereal/packet-vtp.h
  1.3       +6 -1      ethereal/packet-vlan.h
  1.5       +6 -1      ethereal/packet-v120.h
  1.4       +6 -1      ethereal/packet-udp.h
  1.3       +5 -1      ethereal/packet-trmac.h
  1.3       +6 -1      ethereal/packet-tr.h
  1.2       +5 -1      ethereal/packet-tftp.h
  1.5       +6 -1      ethereal/packet-tcp.h
  1.5       +6 -1      ethereal/packet-lapd.h
  1.2       +23 -2     ethereal/packet-stat.h
  1.3       +6 -1      ethereal/packet-sscop.h
  1.5       +6 -1      ethereal/packet-snmp.h
  1.4       +6 -1      ethereal/packet-sna.h
  1.3       +6 -1      ethereal/packet-smb-common.h
  1.2       +5 -1      ethereal/packet-sdp.h
  1.2       +6 -1      ethereal/packet-rtp.h
  1.2       +6 -1      ethereal/packet-rtcp.h
  1.17      +25 -2     ethereal/packet-rpc.h
  1.6       +29 -2     ethereal/packet-rip.h
  1.3       +6 -1      ethereal/packet-raw.h
  1.4       +6 -1      ethereal/packet-q931.h
  1.3       +6 -1      ethereal/packet-q2931.h
  1.4       +6 -1      ethereal/packet-ppp.h
  1.4       +5 -1      ethereal/packet-ipsec.h
  1.4       +23 -2     ethereal/packet-portmap.h
  1.9       +29 -2     ethereal/packet-ospf.h
  1.3       +6 -1      ethereal/packet-null.h
  1.7       +7 -2      ethereal/packet-netbios.h
  1.2       +6 -1      ethereal/packet-ncp-int.h
  1.3       +5 -1      ethereal/packet-nbipx.h
  1.3       +6 -1      ethereal/packet-llc.h
  1.5       +6 -1      ethereal/packet-ldap.h
  1.5       +6 -1      ethereal/packet-lapb.h
  1.2       +6 -1      ethereal/packet-isl.h
  1.10      +5 -1      ethereal/packet-ipx.h
  1.2       +5 -1      ethereal/packet-ipp.h
  1.2       +5 -1      ethereal/packet-http.h
  1.3       +6 -1      ethereal/packet-fddi.h
  1.3       +7 -1      ethereal/packet-eth.h
  1.2       +6 -1      ethereal/packet-diameter.h
  1.3       +6 -1      ethereal/packet-ddtp.h
  1.3       +6 -1      ethereal/packet-clip.h
  1.2       +5 -1      ethereal/packet-cgmp.h
  1.2       +5 -1      ethereal/packet-cdp.h
  1.2       +5 -1      ethereal/packet-bpdu.h
  1.5       +6 -1      ethereal/packet-atm.h
  1.4       +5 -1      ethereal/packet-atalk.h
  1.5       +6 -1      ethereal/packet-ascend.h
  1.7       +6 -1      ethereal/oui.h
  1.5       +5 -1      ethereal/nlpid.h
  1.4       +6 -1      ethereal/inet_v6defs.h
  1.2       +7 -1      ethereal/inet_aton.h
  1.2       +6 -1      ethereal/packet-kerberos.h
  1.205     +9 -8      ethereal/file.c
  1.7       +1 -6      ethereal/tvbuff.h
  1.2       +4 -7      ethereal/ptvcursor.h
  1.20      +1 -3      ethereal/print.h
  1.7       +1 -6      ethereal/plugins.h
  1.4       +1 -6      ethereal/packet-ripng.h
  1.20      +1 -12     ethereal/globals.h
  1.75      +1 -13     ethereal/file.h
  1.7       +1 -3      ethereal/tvbuff.c
  1.2       +1 -3      ethereal/ptvcursor.c
  1.98      +5 -7      ethereal/packet.c
  1.39      +2 -9      ethereal/proto.h
  1.193     +1 -10     ethereal/packet.h
  1.18      +1 -3      ethereal/dfilter.h
  1.117     +4 -6      ethereal/capture.c
  1.34      +3 -1      ethereal/prefs.c
  1.21      +7 -1      ethereal/plugins.c
  1.28      +3 -1      ethereal/column.c
  1.39      +11 -6     ethereal/tethereal.c
  1.4       +3 -1      ethereal/inet_pton.c
  1.4       +3 -6      ethereal/inet_ntop.c
  1.41      +1 -6      ethereal/util.c
  1.80      +5 -11     ethereal/packet-tcp.c
  1.13      +5 -9      ethereal/packet-srvloc.c
  1.9       +6 -11     ethereal/packet-socks.c
  1.4       +4 -9      ethereal/packet-sctp.c
  1.26      +3 -7      ethereal/packet-rsvp.c
  1.8       +6 -9      ethereal/packet-rlogin.c
  1.16      +7 -9      ethereal/packet-pim.c
  1.15      +1 -6      ethereal/packet-ntp.c
  1.8       +6 -11     ethereal/packet-msproxy.c
  1.7       +4 -8      ethereal/packet-mip.c
  1.14      +1 -6      ethereal/packet-ldap.c
  1.8       +5 -9      ethereal/packet-isis-clv.c
  1.25      +3 -7      ethereal/packet-isakmp.c
  1.101     +4 -9      ethereal/packet-ip.c
  1.20      +1 -6      ethereal/packet-icq.c
  1.19      +3 -7      ethereal/packet-icmpv6.c
  1.25      +8 -12     ethereal/packet-bgp.c
  1.9       +4 -11     ethereal/ipproto.c
  1.37      +2 -24     ethereal/dfilter.c
  1.76      +4 -24     ethereal/proto.c
  1.3       +12 -0     ethereal/snprintf.h
  1.10      +1 -1      ethereal/snprintf.c
  1.2       +0 -6      ethereal/snprintf-imp.h