guy 2000/08/06 02:22:44 CDT
Modified files:
. packet-icp.c packet-icq.c
packet-msproxy.c packet-nfs.c
packet-rlogin.c packet-smb-logon.c
packet-socks.c packet-v120.c
Log:
Don't use "fd->pkt_len" when checking to see if you've run off the end
of the packet, use "pi.captured_len" - "fd->pkt_len" may include data
that isn't in the capture, due to a short snapshot length.
Don't use "fd->cap_len" when checking to see if you've run off the end
of the packe, use "pi.captured_len" - "fd->cap_len" isn't adjusted to
reflect any length fields, but "pi.captured_len" is (removing, for
example, Ethernet padding from the packet).
Use "END_OF_FRAME" rather than "pi.captured_len - offset", to make it a
bit clearer what's being done.
In the V.120 dissector, use "tvb_length()" when adding the top-level
protocol tree entry for V.120, as it's a tvbuffified dissector.
Revision Changes Path
1.9 +3 -3 ethereal/packet-icp.c
1.18 +2 -2 ethereal/packet-icq.c
1.5 +3 -3 ethereal/packet-msproxy.c
1.33 +4 -4 ethereal/packet-nfs.c
1.5 +2 -2 ethereal/packet-rlogin.c
1.6 +3 -3 ethereal/packet-smb-logon.c
1.6 +9 -9 ethereal/packet-socks.c
1.10 +2 -2 ethereal/packet-v120.c