Ethereal-cvs: [ethereal-cvs] cvs commit: ethereal packet-rsvp.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Fri, 10 Mar 2000 02:41:08 -0600 (CST)
guy         2000/03/10 02:41:05 CST

  Modified files:
    .                    packet-rsvp.c 
  Log:
  	"ulong" is not a system-declared data type on all platforms;
  
  	casting an arbitrary pointer into a frame to point to something
  	longer than 1 byte, and dereferencing it, is dangerous, as
  	there's no guarantee that said pointer is properly aligned on
  	machines that require alignment;
  
  	the data in an RSVP packet is presumably big-endian in any case,
  	so you should use "pntohl()" to access it, rather than just
  	blithely dereferencing it;
  
  so use "pntohl()" to extract fields from an RSVP packet rather than
  casting pointers to "ulong *" and dereferencing them.
  
  Revision  Changes    Path
  1.16      +6 -6      ethereal/packet-rsvp.c